Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Initial fixed_point Column Support #5704

Merged
merged 82 commits into from
Jul 31, 2020
Merged

[REVIEW] Initial fixed_point Column Support #5704

merged 82 commits into from
Jul 31, 2020

Conversation

codereport
Copy link
Contributor

@codereport codereport commented Jul 16, 2020 •
edited
Loading

This is part 1 of adding support for fixed_point columns. The follow up PR will:

  • Add scale_type into data_type
  • Hook up the thrust::transform_input_output_iterator
  • Customize allocation factory functions (to only allocate for underlying value)

Still to do for this PR:

  • Disable support for certain algorithms
  • Add numeric::decimal64 and corresponding code
  • Make unit tests general to include decimal64
  • Get binaryop working for decimal64

@codereport
Initial changes
eca1349
@codereport
Merge branch 'branch-0.15' into fp-column
274734d
@codereport
Changes to support fixed_point_scalar
6b2a3d1
@codereport
Use default ctor in replace
46de596
@codereport
Add #pragma once
55645b8
@codereport
Use default ctor instead of 0
6d0f39e
@codereport
json/csv decode
3b1c4d2
@codereport
column_view_printer temoprary () operator
3045ddb
@codereport
Changes for algorithms to compile
a056bc5
@codereport
Add TOREVIEW comment
e05591e
@codereport
Add sorted_order and gather tests
7c3efda
@codereport
Remove column_device_printer hack
824fb37
@codereport
Small cleanups
a98c5e6
@codereport
Merge branch 'branch-0.15' into fp-column
e3e8571
@codereport
Remove unused <functional> header
e0f51f8
@codereport
Add missing <type_traits> header
29101ab
@codereport
Remove << ostream operator / iostream
d83fcb2
@codereport
Add changes to support binaryops + unit test (failing)
8fe05c6
@codereport
Final changes for binaryop to work
f2b0b8a
@codereport
Merge branch 'branch-0.15' into fp-column
424347c
@codereport
Merge branch 'branch-0.15' of https://github.com/rapidsai/cudf into b…
dd38812 
…ranch-0.15
@codereport
Add unit test for fixed_point concatenate
ebb929f
@codereport
Add unit test for fixed_point replace
9544fa0
@codereport
Add unit tests for fixed_point upper_bound & lower_bound
1c4a007
@codereport
Remove trailing comma
e69c2c7
@codereport
Add unit test for fixed_point interleave
ec9fbd6
@codereport
Add "scale loop" to interleave unit test
b2ef603
@codereport
Add unit test for fixed_point product reduction
5ca44bd
@codereport
Add unit test for fixed_point sum reduction
1a6f131
@codereport
Merge branch 'branch-0.15' of https://github.com/rapidsai/cudf into b…
3c36662 
…ranch-0.15
@codereport codereport added the 4 - Needs Review Waiting for reviewer to review or respond label Jul 29, 2020
@codereport codereport mentioned this pull request Jul 30, 2020
Closed
harrism
harrism approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @codereport ! Just add that one comment about why simt::std in fixed_point.hpp, otherwise good to go.

@harrism harrism added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Jul 31, 2020
@codereport codereport merged commit b27775c into rapidsai:branch-0.15 Jul 31, 2020
@codereport codereport mentioned this pull request Jul 31, 2020
Merged
@jlowe jlowe mentioned this pull request Jul 31, 2020
Closed
@davidwendt davidwendt mentioned this pull request Aug 5, 2020
Merged
@codereport codereport mentioned this pull request Aug 6, 2020
Merged
15 tasks
@codereport codereport mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad approved these changes

@trevorsm7 trevorsm7 trevorsm7 approved these changes

@harrism harrism harrism approved these changes

@devavret devavret Awaiting requested review from devavret

Assignees

@codereport codereport

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@codereport @GPUtester @harrism @devavret @trevorsm7 @jrhemstad